libnetwork/netavark: do not create config dir in init#2267
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Dec 9, 2024
Merged
libnetwork/netavark: do not create config dir in init#2267openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
Podman creates/initializes the network backend for every command. However most commands will not need it so we should keep the required actions we do to a minimum. In this case the config directory /etc/containers/networks by default as root may not exists and then we try to create it which can fail, i.e. when /etc is read only[1]. The code here are a bit more changes then I would have liked but we must make sure the default in memory network always exists and do not create the directory there. [1] containers#2265 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
@mheon PTAL cc @dustymabe |
Contributor
|
Thank you! |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podman creates/initializes the network backend for every command. However most commands will not need it so we should keep the required actions we do to a minimum.
In this case the config directory /etc/containers/networks by default as root may not exists and then we try to create it which can fail, i.e. when /etc is read only[1].
The code here are a bit more changes then I would have liked but we must make sure the default in memory network always exists and do not create the directory there.
[1] #2265