ci: fixups to golangci lint configuration#2346
Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom Mar 4, 2025
Merged
ci: fixups to golangci lint configuration#2346openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
Conversation
Currently, "make validate" is not used from any CI workflows, meaning it is there for local developer consumption only. For that case, we can safely assume that a developer can maintain a recent golangci-lint installation. This also fixes the problem of golangci-lint version discrepancy between Makefile and .github/workflows/validate.yml, introduced by commit 9378a51 ("renovate: teach it to update the lint version"). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This fixes the following warnings from golangci-lint v1.64.6: WARN [lintersdb] The linter "gomnd" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle WARN [lintersdb] The linter "execinquery" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It is not used since commit 08e77b2 ("cirrus-ci: rm make validate"). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Makefile: rm golangci-lint installation
Currently, "make validate" is not used from any CI workflows, meaning
it is there for local developer consumption only. For that case, we
can safely assume that a developer can maintain a recent golangci-lint
installation.
This also fixes the problem of golangci-lint version discrepancy between
Makefile and .github/workflows/validate.yml, introduced by commit 9378a51
("renovate: teach it to update the lint version").
2. ci: rm deprecated linters from .golangci.yml
This fixes the following warnings from golangci-lint v1.64.6:
(observed since at least #2323)
3. .cirrus.yml: rm GOLANGCILINT_CACHE
It is not used since commit 08e77b2 ("cirrus-ci: rm make validate").