[v1.9] Backport nix derivation for static builds#6408
[v1.9] Backport nix derivation for static builds#6408hswong3i wants to merge 1 commit intocontainers:v1.9from
Conversation
|
Hi @hswong3i. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
You need to add a Signed-off-by line to your commit - |
0fff877 to
0058968
Compare
|
LGTM |
bb8b533 to
3960d97
Compare
|
I have no expertise in Nix and cannot review. |
Could simply try with this: Example result: |
|
@saschagrunert PTAL |
3960d97 to
cf53d3d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hswong3i, saschagrunert The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
867ad11 to
cee93bc
Compare
Signed-off-by: Wong Hoi Sing Edison <hswong3i@gmail.com>
cee93bc to
6953dbc
Compare
|
Compile now successful: https://github.com/alvistack/libpod/releases/download/v1.9.3/podman-v1.9.3-linux-amd64 Static binaries:
Therefore could focus on CI/CD fixes ;-) |
|
/ok-to-test |
|
Can you rebase the commits? |
Checked and already rebased and updated with v1.9 |
|
Tests are still failing. |
|
Let's focus on master ;-) |
Also see #6402
nix-based static binary could be found from: