Skip to content

Fixing static binary build using container #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vijaySamanuri wants to merge 2 commits into from
Closed

Fixing static binary build using container #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e98dfe
Fixing static build using container
vijaysamanuriWM Jun 11, 2019
4660a3b
Merge branch 'master' into master
vijaySamanuri Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Dockerfile.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
FROM ubuntu:18.10

RUN apt-get update && apt-get install -y \
golang \
libbtrfs-dev \
RUN apt-get update && apt-get install -y wget
RUN wget -P /tmp/ https://dl.google.com/go/go1.11.linux-amd64.tar.gz && \
tar -xvf /tmp/go1.11.linux-amd64.tar.gz -C /usr/local/

ENV GOROOT /usr/local/go
ENV GOPATH /
ENV PATH $GOPATH/bin:$GOROOT/bin:$PATH

RUN apt-get install -y libbtrfs-dev \
git-core \
libdevmapper-dev \
libgpgme11-dev \
go-md2man \
libglib2.0-dev \
libostree-dev

ENV GOPATH=/
WORKDIR /src/github.com/containers/skopeo
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ LOCAL_BUILD_TAGS = $(BTRFS_BUILD_TAG) $(LIBDM_BUILD_TAG) $(OSTREE_BUILD_TAG) $(D
BUILDTAGS += $(LOCAL_BUILD_TAGS)

ifeq ($(DISABLE_CGO), 1)
override BUILDTAGS = containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp
override BUILDTAGS = netgo osusergo containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac Jun 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

  • netgo bypasses NSS, including the glibc resolver (per https://golang.org/pkg/net/ , e.g. breaking .local names.
  • osusergo bypasses NSS as well, breaking e.g. LDAP uses.

Yes, I realize that these downsides are fundamentally necessary to make static builds work at all, but they are significant downsides.

I’m sorely tempted to just remove any mention of statically-linked or non-CGo builds from the repository (@rhatdan WDYT?).

If not that, at the very least README should document these downsides of a static build as well.

Copy link
Copy Markdown
Member

@rhatdan rhatdan Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hate to remove them, since it seems many in the GO world seem to want/require them. I guess Documenting the shortcomings is the best solution.

The NSS stuff is only important for rootless container/storage I believe?

endif

# make all DEBUG=1
Expand Down