Skip to content
This repository was archived by the owner on Apr 3, 2018. It is now read-only.

Fix network warning message#502

Merged
sboeuf merged 1 commit into
containers:masterfrom
jodh-intel:fix-network-warning-message
Dec 11, 2017
Merged

Fix network warning message#502
sboeuf merged 1 commit into
containers:masterfrom
jodh-intel:fix-network-warning-message

Conversation

@jodh-intel
Copy link
Copy Markdown
Collaborator

getLinkByName() was making a log call but specifying the wrong logging
function meaning the parameters were not being logged correctly.

Fixes #501.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

getLinkByName() was making a log call but specifying the wrong logging
function meaning the parameters were not being logged correctly.

Fixes containers#501.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@grahamwhaley
Copy link
Copy Markdown
Contributor

nice little catch. I ran a couple of greps to see if there were any more like that, or the inverse (calling warnf with no % modifiers - as my mind tells me that is something I have seen go past my eyes...). Nothing leapt out.

We have a F26 CI failure - I strongly suspect unrelated, but for ref (/cc @amshinde @chavafg )

12:37:02 ok  	github.com/containers/virtcontainers	16.222s
12:37:09 Some output on stderrtime="2017-12-11T12:37:09Z" level=error msg="hook error" error="exit status 1: stdout: , stderr: " hook-type=pre-start source=virtcontainers subsystem=hooks
12:37:57 BenchmarkCreateStartStopDeletePodQemuHypervisorNoopAgentNetworkCNI-4   	--- FAIL: BenchmarkCreateStartStopDeletePodQemuHypervisorNoopAgentNetworkCNI-4
12:37:57 	api_test.go:1729: Could not delete pod: running [/usr/sbin/iptables -t nat -D POSTROUTING -s 10.88.0.34/16 -j CNI-43621ab25fddc3dba3fe8fe8 -m comment --comment name: "mynet" id: "8fede512-beaa-4b3c-9d85-c5a2bc47d8f4-0" --wait]: exit status 2: iptables v1.6.1: Couldn't load target `CNI-43621ab25fddc3dba3fe8fe8':No such file or directory
12:37:57 		
12:37:57 		Try `iptables -h' or 'iptables --help' for more information.
12:37:57 FAIL
12:37:57 exit status 1
12:37:57 FAIL	github

I'll kick a rebuild

@jodh-intel
Copy link
Copy Markdown
Collaborator Author

@grahamwhaley - yep. I'll try to get round to updating clearcontainers/tests#590 (including adding a check for rogue format specifiers) as we need to be able to run such a tool as part of the CI imho for CC + kata.

@sboeuf
Copy link
Copy Markdown
Collaborator

sboeuf commented Dec 11, 2017

LGTM

Approved with PullApprove Approved with PullApprove

@sboeuf sboeuf merged commit dc23a7e into containers:master Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants