This repository was archived by the owner on Apr 3, 2018. It is now read-only.
Fix network warning message#502
Merged
Merged
Conversation
getLinkByName() was making a log call but specifying the wrong logging function meaning the parameters were not being logged correctly. Fixes containers#501. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
grahamwhaley
approved these changes
Dec 11, 2017
Contributor
|
nice little catch. I ran a couple of greps to see if there were any more like that, or the inverse (calling warnf with no % modifiers - as my mind tells me that is something I have seen go past my eyes...). Nothing leapt out. We have a F26 CI failure - I strongly suspect unrelated, but for ref (/cc @amshinde @chavafg ) I'll kick a rebuild |
Collaborator
Author
|
@grahamwhaley - yep. I'll try to get round to updating clearcontainers/tests#590 (including adding a check for rogue format specifiers) as we need to be able to run such a tool as part of the CI imho for CC + kata. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getLinkByName() was making a log call but specifying the wrong logging
function meaning the parameters were not being logged correctly.
Fixes #501.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com