feat: Bindings for dedicated ingredient archives APIs#223
Open
tmathern wants to merge 6 commits into
Open
Conversation
Collaborator
Author
|
(Needs a c2pa-rs release for all tests to pass + contentauth/c2pa-rs#2164). Update: https://github.com/contentauth/c2pa-rs/releases/tag/c2pa-v0.85.0, https://github.com/contentauth/c2pa-rs/releases/tag/c2pa-c-ffi-v0.85.0 |
ok-nick
reviewed
May 28, 2026
Comment on lines
+450
to
+451
| | Dedicated ingredient archive APIs | `add_ingredient` then `write_ingredient_archive(id, stream)` | **Current** | | ||
| | Read-filter-rebuild APIs | `Builder` + `add_ingredient` + `to_archive`, then `Reader` + manual JSON | **Legacy** (see [catalog migration guide](#migration-guide-catalog-pattern) and [extraction migration guide](#migration-guide-ingredient-extraction)) | |
Contributor
There was a problem hiding this comment.
There's such thing as builder archives and ingredient archives still? Ingredient archives don't necessarily replace builder archives, do they?
Collaborator
Author
There was a problem hiding this comment.
Eventually I'd like ingredient archives to be their own things and replace the "legacy" way. But we're not at the point of deprecation just yet, only exposing the APIs and making them interchangeable.
I think it will be clearer to have them dedicated concepts with dedicated APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_ingredient_archiveandadd_ingredient_from_archive.(As often happening, the bulk of the changes explaining the line count are the tests and the docs).