chore(google-docs): remove dev-only fixture review payload [INTEG-3802]#10900
Open
ryunsong-contentful wants to merge 1 commit intomasterfrom
Open
chore(google-docs): remove dev-only fixture review payload [INTEG-3802]#10900ryunsong-contentful wants to merge 1 commit intomasterfrom
ryunsong-contentful wants to merge 1 commit intomasterfrom
Conversation
ryunsong-contentful
force-pushed
the
INTEG-3802
branch
from
9cee8f9 to
8e5e58a
Compare
Joaquin (joaquincasal)
approved these changes
Apr 21, 2026
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| interface ImportMetaEnv { | |||
| readonly VITE_ENABLE_MOCK_EDIT_MODAL?: string; | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| readonly VITE_ENABLE_MOCK_EDIT_MODAL?: string; |
I think we can remove this one as well
Comment on lines
5
to
6
| # Frontend (Vite): dev-only UI to preview the exclude/edit modal inside the mapping view. | ||
| VITE_ENABLE_MOCK_EDIT_MODAL= |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Frontend (Vite): dev-only UI to preview the exclude/edit modal inside the mapping view. | |
| VITE_ENABLE_MOCK_EDIT_MODAL= |
Same as above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTEG-3802
Summary
loadFixtureReviewPayloadfixture andVITE_ENABLE_MOCK_REVIEW_PAYLOADenv flag that were always markedTODO: remove before launchPage.tsxand all associated imports, state, and type declarationsMappingView) now that the fixture mock is goneTest plan
Page.spec.tsxpasses with the updated mock labelVITE_ENABLE_MOCK_REVIEW_PAYLOADorloadFixtureReviewPayloadremain in the codebaseGenerated with Claude Code