fix(google-docs): rail card spacing + pre-select current locations in edit modal []#10942
Draft
Mitch Goudy (mgoudy91) wants to merge 2 commits intomasterfrom
Draft
fix(google-docs): rail card spacing + pre-select current locations in edit modal []#10942Mitch Goudy (mgoudy91) wants to merge 2 commits intomasterfrom
Mitch Goudy (mgoudy91) wants to merge 2 commits intomasterfrom
Conversation
…fsets exceed group height ResizeObserver remeasures card positions whenever a card grows, and the rail inner box now enforces a minHeight equal to the bottom of the lowest card so pushed-down cards don't bleed into the next content group. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…edit modal, fix tests for view/edit mode split - ResizeObserver remeasures card positions on resize; rail minHeight grows to fit pushed-down cards - EditModal now pre-selects all current location buttons so Reassign/Exclude is enabled by default; unchecking explicitly removes a location - Add ResizeObserver stub to test setup (jsdom doesn't implement it) - Update MappingView and EditModal tests to reflect new pre-selected behavior and mode="edit" requirement after INTEG-3858 view/edit split Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Mitch Goudy (mgoudy91)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while testing INTEG-3848 locally. Three fixes on top of master, intended to complement Harika's
fix/reassignwork.ResizeObserverremeasures card positions whenever a card grows (e.g. after a mapping edit adds a field label); rail inner box now enforcesminHeightequal to the bottom edge of the lowest card, preventing overflow into adjacent groupsselectedLocationIdsnow initializes with all current location IDs so the Reassign/Exclude button is enabled by default. Unchecking a location explicitly removes it — matches the AC in INTEG-3848: "only remove the current location mapping if the user unchecks it"ResizeObserverstub to jsdom setup; updatedMappingViewandEditModaltests to reflect new pre-selected behavior andmode="edit"requirement after INTEG-3858 introduced the view/edit mode splitTesting
Load the mock fixture (
VITE_ENABLE_MOCK_REVIEW_PAYLOAD=true), open Edit on a block mapped to multiple fields — button should be immediately enabled, cards should not overlap after edits.All 110 tests pass locally.