Feat/throw error for unavailable nested fields#38
Merged
Deepak-Kharah merged 22 commits intomasterfrom Jul 28, 2022
Merged
Conversation
This issue occured due to improper query param formed. The resolution was to make it closer to what APIs use.
referring to same test data creates an unsanitized environment for the next test environment after the packages has been updated to latest release due to the vulnerabilities fixed as per the SRE report.
- updated package version - updated docs - updated build - updated subresource integrity hash - update readme file
The entry data is empty when the user is on the create new page. This would work if getField is used to fetch root elements. But, when we try to fetch the nested elements it fails with no useful information to the user. Hence, in order to have a consistent output, we are throwing an error for all the getField() calls within the new entry page. We determine whether the page is in create mode or edit mode by checking if the entry is present. Because entry data is not passed to SDK when it is in create page. Please Note: Since, we allow only custom fields within the create new entry page, this change only applys to the custom fields. fixes: CS-27725
hiteshshetty-dev
approved these changes
Jun 23, 2022
thinknikhil
approved these changes
Jul 28, 2022
aravindbuilt
approved these changes
Jul 28, 2022
kego1992
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entry data is empty when the user is on the create the new page. This
would work if getField is used to fetch root elements. But, when we try
to fetch the nested elements it fails with no useful information to the
user. Hence, to have a consistent output, we are throwing an
error for all the getField() calls within the new entry page.
We determine whether the page is in create mode or edit mode by
checking if the entry is present. Because entry data is not passed to
SDK when it is on the create page.
Please Note: Since we allow only custom fields within the create new
entry page, this change only applies to the custom fields.
fixes: CS-27725