fix: kubectl run creates pod not deployment#20
Merged
sublimino merged 6 commits intocontrolplaneio:masterfrom May 6, 2020
denhamparry:master
Merged
fix: kubectl run creates pod not deployment#20sublimino merged 6 commits intocontrolplaneio:masterfrom denhamparry:master
sublimino merged 6 commits intocontrolplaneio:masterfrom
denhamparry:master
Conversation
added 6 commits
May 6, 2020 10:35
- kubectl run creates pods, not deployments - deployments are expected in the introduction exercise
- services created by kubectl run - service required to access pods in demo
- labels `role` value preceeded with `test-`
- combine deployments into single yaml
- Removed kubectl run from make test-deploy - kubectl run creates a pod not a deployment - Deployments created using demo.yaml
- fix bash script for kubectl apply - refactor to single apply command
Member
|
Nice one @denhamparry, thank you ⚡🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
kubectl runcreates a pod when a deployment is expected.yaml.role: test-...)