Skip to content
This repository was archived by the owner on Apr 13, 2022. It is now read-only.

#103 Dedup and sort licenses in updating licenses task#104

Merged
k4zy merged 1 commit intocookpad:masterfrom
AlanChiou:Alan/sort-dependencies
May 17, 2021
Merged

#103 Dedup and sort licenses in updating licenses task#104
k4zy merged 1 commit intocookpad:masterfrom
AlanChiou:Alan/sort-dependencies

Conversation

@AlanChiou
Copy link
Contributor

To make licenses YAML file easy to be review and manage,
we should keep licenses a fixed order which is the alphabetical sort by
licence artifact ids.

Test: unit tests pass

To make licenses YAML file easy to be review and manage,
we should keep licenses a fixed order which is the alphabetical sort by
licence artifact ids.

Test: unit tests pass
@AlanChiou AlanChiou changed the title Dedup and sort licenses in updating licenses task #104 Dedup and sort licenses in updating licenses task Apr 30, 2021
@AlanChiou
Copy link
Contributor Author

AlanChiou commented Apr 30, 2021

#103

@AlanChiou AlanChiou changed the title #104 Dedup and sort licenses in updating licenses task #103 Dedup and sort licenses in updating licenses task Apr 30, 2021
Copy link
Contributor

@k4zy k4zy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. Thank you!

@k4zy k4zy merged commit 0547361 into cookpad:master May 17, 2021
@k4zy k4zy mentioned this pull request May 17, 2021
1 task
@AlanChiou AlanChiou deleted the Alan/sort-dependencies branch May 21, 2021 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants