Skip to content

⚡ Bolt: [performance improvement]#58

Open
coredipper wants to merge 1 commit into
mainfrom
bolt-on-deduplication-16295306975210764240
Open

⚡ Bolt: [performance improvement]#58
coredipper wants to merge 1 commit into
mainfrom
bolt-on-deduplication-16295306975210764240

Conversation

@coredipper

Copy link
Copy Markdown
Owner

💡 What: Replaced several instances of O(N²) list deduplication (using if item not in seen_list: seen_list.append(item)) with O(N) hash-based deduplication (list(dict.fromkeys(...))).
🎯 Why: Because checking membership in a Python list is an O(N) operation, doing it inside a loop over N items creates an O(N²) algorithmic bottleneck. Using dictionaries (which preserve insertion order in Python 3.7+) reduces this to O(N).
📊 Impact: Expected performance improvement in loops processing collections of sources and markers while producing functionally identical ordered output.
🔬 Measurement: Run the test suite (cd scrip && uv run pytest tests/ and cd harness && uv run pytest tests/) to verify correct order preservation and deduplication.


PR created automatically by Jules for task 16295306975210764240 started by @coredipper

Co-authored-by: coredipper <1830173+coredipper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant