-
Notifications
You must be signed in to change notification settings - Fork 458
[WIP] - Feat/reformat volume #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mbellehumeur
wants to merge
68
commits into
cornerstonejs:main
Choose a base branch
from
mbellehumeur:feat/reformatVolume
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] - Feat/reformat volume #2510
mbellehumeur
wants to merge
68
commits into
cornerstonejs:main
from
mbellehumeur:feat/reformatVolume
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… viewport options and improved UI elements
…nhance dynamic loading options
…and add decimateImagePixels utility
…cessing and update image loading logic
…ume and StreamingImageVolume; adjust decimation logic in decimateVolumeLoader
…button creation in the example
… cases; update spacing calculations
…s for improved accuracy
…s by using Math.floor for new dimensions
…age decimation, including parameter descriptions, examples, and value changes
…ers with a single ijkDecimation array for improved clarity and flexibility; update related interfaces and example usage
…ust metadata handling; modify example to disable progressive rendering for now
… defaults and adjust viewport handling
…emove unnecessary console logs and improve progressive rendering access
… excessive logging in StreamingImageVolume and enhancedVolumeLoader for cleaner output
…treamline console output by removing unnecessary logs while maintaining essential information for improved clarity during volume loading.
…post-processing functionality and related comments, streamline volume loading logic by eliminating unnecessary prefetching and logging, and adjust decimation factors in example for improved performance.
…n. Improve variable naming (i,j,k instead of x,y,z) , align initial volume orientation with scan direction.
…lities, parameters, and return structure. Remove deprecated image post-processing comment from StreamingImageVolume for cleaner code.
Not used anymore. decodeImageFrame creates the pixelData.
…g and integration with BaseStreamingVolume, including target dimensions and PixelData decoding process.
…r/cornerstone3D into feat/dynamic-loading
…nd simplify loadImage logic in WADO loaders. Clean up redundant method in BaseVolumeViewport.
… and simplify return statements in getVolumeId method. Remove unnecessary line breaks in loadImage functions across WADO loaders.
… loads, transferSyntaxUID extraction andcheckDimensionGroupCompletion method.
…vtkActor to unknown as Types.Actor for improved type safety.
… from any to unknown as Types.Actor for enhanced type safety and clarity.
…on and getConfiguration from @cornerstonejs/core to streamline the codebase.
…y of volume loading functionalities.
Merge branch 'main' of https://github.com/mbellehumeur/cornerstone3D into feat/dynamic-loading
…nsion for consistency
…test case for row factor omission
…into feat/dynamic-loading
…d add helper function for orientation calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ticket: 18376010119
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment