This repository was archived by the owner on May 16, 2023. It is now read-only.
Feature/refactor trace time warning distribution tests#1357
Merged
Conversation
FelixRottler
requested review from
a team,
AliceBilc,
alexmoroianu and
roesslerj
hilmarf
approved these changes
Apr 30, 2021
roesslerj
approved these changes
May 7, 2021
ioangut
approved these changes
May 7, 2021
hilmarf
reviewed
May 7, 2021
Comment on lines
-3
to
-4
| import static app.coronawarn.server.services.distribution.assembly.appconfig.YamlLoader.loadYamlIntoProtobufBuilder; | ||
| import static java.io.File.separator; |
Member
There was a problem hiding this comment.
@FelixRottler please check your IDE settings for import organization... as per checkstyle rules, statics should be at the top
hilmarf
reviewed
May 7, 2021
| import java.util.Random; | ||
| import java.util.Set; | ||
| import java.util.UUID; | ||
| import java.util.*; |
Member
There was a problem hiding this comment.
@FelixRottler please check your IDE settings for import organization... normally we try to avoid .* imports
|
Kudos, SonarCloud Quality Gate passed!
|
hilmarf
deleted the
feature/refactor-trace-time-warning-distribution-tests
branch
roesslerj
added a commit
that referenced
this pull request
May 17, 2021
* main: Feature/dgc improvements (#1378) Bump wiremock-jre8 from 2.27.2 to 2.28.0 (#1381) Feature/refactor trace time warning distribution tests (#1357) Bump protobuf.version from 3.15.8 to 3.16.0 (#1375) groupId: app.coronawarn.server (#1377) Changed the endpoint-URL and rename 'valuesets' config param and env variable (#1376) refactor: add testcontainer to spin up s3 cloudserver instead of usin… (#1374) fix warning for SSLHostConfig (#1372) Feature/digital green certificate (#1373) Bump jacoco-maven-plugin from 0.8.6 to 0.8.7 (#1370) Bump feign.version from 11.1 to 11.2 (#1369)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces additional tests for trace time warnings