Add delay timer when attaching go tls uprobes to a process#326
Open
vishnukumarkvs wants to merge 1 commit into
Open
Add delay timer when attaching go tls uprobes to a process#326vishnukumarkvs wants to merge 1 commit into
vishnukumarkvs wants to merge 1 commit into
Conversation
Member
|
I like the general approach, but there's a concurrency issue. I don't have a concrete alternative yet, I need to look at the code more closely, but I think we should aim to keep the attach on the event-loop goroutine rather than introducing a separate timer/goroutine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added TlsInstrumentationDelay flag (default 5s) to skip TLS uprobe attachment for short-lived processes (e.g., exec probes). When a process is younger than the timeperiod, uprobe attachment is delayed instead of running immediately.
This way, we can skip attaching uprobes for short process like liveliness/readiness probes