build: bump pyroscope/ebpf fork for CPython 3.14 support#330
Draft
gecube wants to merge 1 commit into
Draft
Conversation
Repoint the github.com/grafana/pyroscope/ebpf replace at the fork commit that adds the CPython 3.14 offset table, so node-agent profiles Python 3.14 processes instead of failing with "unsupported python version". Fixes coroot#318. Draft note: temporarily pinned to the coroot/pyroscope#3 branch. Before merge this will be repointed to the coroot/pyroscope commit once coroot#3 lands. Signed-off-by: Gaál György <gb12335@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Python 3.14 processes aren't profiled today: the eBPF Python unwinder (from
github.com/grafana/pyroscope/ebpf,replaced with thecoroot/pyroscopefork) has no offset table for 3.14, soGetUserOffsetsreturnsunsupported versionand no profiles are produced. Reported in #318.This bumps the fork pin to the commit that adds the CPython 3.14 offset table:
(pyroscope-side change: coroot/pyroscope#3)
Verification
go mod tidyclean;go build ./profiling/andgo vet ./profiling/pass with the bumped dependency.python:3.14.6process (same PID), eBPF session withPythonEnabled:pyperf get python process data failed err="unsupported python version ... {3 14 6}"pyperf process profiling init success ... Version:{Major:3 Minor:14 Patch:6}Before marking ready
replacefrom thegecubefork commit to thecoroot/pyroscopecommitgo mod tidyFixes #318.