production release - #524
Merged
Merged
Conversation
A full-database validation sweep (every row through full_clean()) found 31
rows whose values were never valid against the models as declared here.
Django enforces choices and blank= in its validation layer, which the write
paths that produced these rows did not run, so the database accepted them.
purchasing/0009: deletes 12 purchase-order lines that hold nothing at all
(blank description, qty 1, no cost, nothing received, no job, no Xero id, no
item codes, no raw payload, price_tbc unset); describes the 5 blank-
description lines that DO carry data, one of which has 2 units received at
$119.50 against a job; and maps the single status 'void' -> 'deleted'.
quoting/0004: unsets 13 mapped_metal_type values that were never valid
choices ('unspecified' x10, 'steel' x2, 'tungsten' x1) and clears their
parser_version so the parser re-derives them, skipping any row an operator
has hand-validated.
Verified by replaying both migrations against a restore of production inside
a transaction: 12/5/1/13 rows affected, leaving zero blank descriptions,
zero 'void' statuses and zero out-of-enum metal types.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013wDoeUfmKL3AnXzpYToyPk
Repair data that violates this project's own field contracts
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Short explanation of what you’ve built and why.
🔗 Related Jira Work Item
Jira: KAN-123
Use the uppercase Jira key (
KAN-123) in the PR title or body so GitHub forJira links the development event. Jira Automation owns the transition to Done
when the PR is merged.
🚀 Changes
useChatcomposable, splitChatHistoryandChatInputcomponents, added Pinia store).✅ Checklist
Vue.js (Composition API)
<script setup>& composables), no heavy logic in templatesuseChat, etc.)propsandemit, no direct parent/child ref duplicationQuality & Formatting
npx prettier --check .)npx eslint . --ext .js,.ts,.vue)Definition of Done
anyor loose passthrough types reviewedSee docs/jira-usage.md#required-checks.