added future training flag to AlyxPanel#73
added future training flag to AlyxPanel#73k1o0 merged 2 commits intocortex-lab:devfrom jkbhagatio:dev
Conversation
|
This is very hard to review :/ Did you change the order of the methods or did do something weird? It seems to think ever line was changed |
|
ah, did smart-indent on the file = D |
|
That makes sense. I change my smart indent to be 2 spaces instead of four. Four seems like too much to me. It bugs me about Python too... |
|
haha I was wondering when we'd get to the difference in stylistic preferences... |
|
I also prefer spaces around equals signs because it improves readability, and try to use as informative variable names as possible, even if they're quite long. Particularly if it doesn't cause a line to run on there's no disadvantage to having long variable names. When Pip first joined the lab all of his variables were four letters long and no one could read his code. |
k1o0
left a comment
There was a problem hiding this comment.
Just add a line to print training prefs to the log, i.e. 'LEW010 marked for training on Saturday, Sunday and Tuesday'. Also try to stick as close as possible to the current style of the class/function, which was mostly inherited from Chris (except for the two space indent).
|
hmm, yeah I sometimes don't do the whitespace around expression bindings because some languages don't read it, and I prefer shorter variable names, though I almost always explain all variable names in a comment |
|
updated as per your request |
added future training flag to AlyxPanel
No description provided.