add/support enabled_tenants and disabled_tenants feature in storegateway

[moki1202]

Signed-off-by: Shashank shashanksingh819@gmail.com

What this PR does: Now adds/supports enabled_tenants and disabled_tenants in package storegateway

Fixes #5133

Checklist

• Tests updated
• Documentation added
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

PR still in progress.

[moki1202]

@friedrichg Do I need to create a new function to filter out users that are not allowed?

[friedrichg]

@moki1202 Store-gateways download the bucket index for the tenant and all the blocks. I would expect that this PR to ignore users discovered in S3 that are not allowed. a new function is not required, use allowedTenants.IsAllowed
See this PR for an example

[moki1202]

@friedrichg Is there a function/map that stores all the incoming users in the bucket? I tried finding it in the stores field but had no luck.

[friedrichg]

@moki1202 filterUsers function is already in the right places

cortex/pkg/storegateway/bucket_index_metadata_fetcher.go

Line 61 in 47733dd

if len(f.strategy.FilterUsers(ctx, []string{f.userID})) != 1 {

cortex/pkg/storegateway/bucket_stores.go

Line 212 in 47733dd

for _, userID := range u.shardingStrategy.FilterUsers(ctx, userIDs) {

Concentrate making changes on https://github.com/cortexproject/cortex/blob/master/pkg/storegateway/sharding_strategy.go
to implement this feature on both normal sharding and shuffle sharding
and don't forget to update/include tests in sharding_strategy_test.go

[moki1202]

@moki1202 filterUsers function is already in the right places

cortex/pkg/storegateway/bucket_index_metadata_fetcher.go

Line 61 in 47733dd

if len(f.strategy.FilterUsers(ctx, []string{f.userID})) != 1 {

cortex/pkg/storegateway/bucket_stores.go

Line 212 in 47733dd

for _, userID := range u.shardingStrategy.FilterUsers(ctx, userIDs) {

Concentrate making changes on https://github.com/cortexproject/cortex/blob/master/pkg/storegateway/sharding_strategy.go to implement this feature on both normal sharding and shuffle sharding and don't forget to update/include tests in sharding_strategy_test.go

understood! I'll try this.

[moki1202]

@friedrichg I've tried a lot but I am struggling while updating the tests. Can you please help me out here? I would just ask for your help in updating the defaultShardingStrategy tests. I'll try doing the other ones after.

[friedrichg]

No, we need the GetShuffleShardingSubring on the filtered users, otherwise we might end up with store-gateways running without users

[friedrichg]

Unfortunately, this function does not test FilterUsers, it tests FilterBlocks. So this is not the right place

[friedrichg]

Thanks, partially included in #5638