Add user label to ruler query and write metrics#5312
Conversation
alvinlin123
left a comment
alvinlin123
left a comment
There was a problem hiding this comment.
overall looks good, but I think some test should be updated/added for the user label.
|
The change looks okay to me. Please make sure we mention the metrics we are going to change in the changelog. |
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Looks good, like Alvin says: just add 1 test using testutil.GatherAndCompare
alvinlin123
left a comment
alvinlin123
left a comment
There was a problem hiding this comment.
Nice enhancement, but I think something is wrong with the PR; it includes changes that are already in the cortexporject:master branch. Can you fix this before I merge this PR?
| docker pull quay.io/cortexproject/cortex:v1.14.0 | ||
| docker pull quay.io/cortexproject/cortex:v1.14.1 | ||
| docker pull quay.io/cortexproject/cortex:v1.15.0 | ||
| docker pull quay.io/cortexproject/cortex:v1.15.1 |
There was a problem hiding this comment.
this looks like a change that is already in cortexproject:master
| cmd/cortex/cortex | ||
| cmd/query-tee/query-tee | ||
| cmd/thanosconvert/thanosconvert | ||
| cmd/test-exporter/test-exporter-* |
There was a problem hiding this comment.
this looks like a change that is already in cortexproject:master
rajagopalanand
force-pushed
the
master
branch
3 times, most recently
from
85b384a to
f443580
Compare
…ser level Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
5 participants
What this PR does:
Adding user label to cortex_ruler_queries_failed_total, cortex_ruler_queries_total, cortex_ruler_write_requests_failed_total, cortex_ruler_write_requests_total metrics. This would allow for better tracking of failures at a user level
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]