Add stats log when querying store gateway#5376
Merged
Merged
Conversation
yeya24
force-pushed
the
store-gateway-stats
branch
from
2d1aff6 to
b5c8812
Compare
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
store-gateway-stats
branch
from
b5c8812 to
a59bdc2
Compare
Contributor
Author
|
I am thinking if we need to log stats per store gateway request or we only log the aggregated stats for all store gateway for a query. The previous option is more verbose but better to maybe identify query skews for different store gateways. |
Signed-off-by: Ben Ye <benye@amazon.com>
friedrichg
approved these changes
Jun 2, 2023
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Thanks!
I think is fine without aggregation, we lose important detail with aggregation
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Contributor
Author
|
I will go ahead and merge the pr. |
cathy-qiu
pushed a commit
to cathy-qiu/cortex
that referenced
this pull request
Jun 7, 2023
* add stats log when querying store gateway Signed-off-by: Ben Ye <benye@amazon.com> * update changelog Signed-off-by: Ben Ye <benye@amazon.com> * add data_downloaded_size_sum Signed-off-by: Ben Ye <benye@amazon.com> * update vendor Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Cathy Qiu <cathyqiu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add series stats log in querier to log request stats going to each store gateway. This was added to Thanos recently thanos-io/thanos#6352.
Example:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]