use caching bucket for compactor, except cleaner#5682
Merged
Conversation
yeya24
reviewed
Dec 5, 2023
yeya24
reviewed
Dec 5, 2023
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Let's also add unit tests in compactor_test.go to make sure it works as expected
wenxu1024
force-pushed
the
caching-bucket-compactor
branch
from
6a516da to
e7f39a2
Compare
yeya24
reviewed
Dec 7, 2023
Signed-off-by: Wen Xu <wenxuamz@amazon.com>
…r and tenant deletion marker for compactor Signed-off-by: Wen Xu <wenxuamz@amazon.com>
…to the feature flag Signed-off-by: Wen Xu <wenxuamz@amazon.com>
Signed-off-by: Wen Xu <wenxuamz@amazon.com>
Signed-off-by: Wen Xu <wenxuamz@amazon.com>
wenxu1024
force-pushed
the
caching-bucket-compactor
branch
from
e8885ed to
3c58f66
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use Caching Bucket for compactor operations, except the cleaner which serves as the source of truth for tenant bucket index.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]