Fix typos in code and docs#5784
Merged
Merged
Conversation
Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
codespell-2-22-2024
branch
from
9b9c279 to
2577e7a
Compare
friedrichg
reviewed
Feb 23, 2024
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
@CharlieTLe thanks!. Can you run make docs so the lint passes?
Member
|
Thanks! Probably some of the docs are generated so you just need to change in the code and generate the doc again. that's why probably the lint is failing. |
Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
commented
Feb 23, 2024
| [client_ca_file: <string> | default = ""] | ||
|
|
||
| # Register the instrumentation handlers (/metrics etc). | ||
| # Register the intrumentation handlers (/metrics etc). |
Member
Author
There was a problem hiding this comment.
This seems to be coming from https://github.com/weaveworks/common/blob/master/server/server.go#L154 which is outside of this repo.
Member
There was a problem hiding this comment.
that is true and any weaveworks repo is probably already archived.
We can fix this in another PR.
friedrichg
approved these changes
Feb 26, 2024
friedrichg
reviewed
Feb 26, 2024
friedrichg
reviewed
Feb 26, 2024
friedrichg
requested changes
Feb 26, 2024
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Thanks again for your contribution. It's a large PR. Took another pass and saw some things. can you comment or fix them?
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
friedrichg
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes typos in code and docs
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]