Add new query inflight request on ingester#6081
Merged
Merged
Conversation
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
f120c4e to
509dbab
Compare
CharlieTLe
reviewed
Jul 11, 2024
CharlieTLe
reviewed
Jul 11, 2024
CharlieTLe
reviewed
Jul 11, 2024
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
0ea7514 to
45c104e
Compare
CharlieTLe
reviewed
Jul 12, 2024
Member
CharlieTLe
left a comment
There was a problem hiding this comment.
Thanks for doing this. I was wondering why defer is used in some places and not others.
Contributor
Author
|
@CharlieTLe |
CharlieTLe
reviewed
Jul 12, 2024
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
alanprot
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR extended work done at #5798.
From tests, it was noticed that the metrics is accurate but does not show the impacting volume on ingester. I am proposing to remove from the metric any pre and post execution and count the metric only when the ingester is actually resolving the query. That from tests is when we see issues with CPU usage on ingesters.
Also adding a new ingester instance limit, similar to the existent
max_inflight_push_requeststo limit the max number of inflight queries on ingesters. The reads are from any GET operation on ingesters.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]