Remove references to max_series_per_query from docs#6889
Conversation
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Thanks for catching this. Just some small comments. Maybe we can replace max_series_per_query to the new limit name and also remove max_samples_per_query
| tenant1: | ||
| ingestion_rate: 10000 | ||
| max_series_per_metric: 100000 | ||
| max_series_per_query: 100000 |
There was a problem hiding this comment.
We can probably change max_series_per_query to max_fetched_series_per_query as it is the new limit.
| max_series_per_metric: 100000 | ||
| max_series_per_query: 100000 | ||
| tenant2: | ||
| max_samples_per_query: 1000000 |
There was a problem hiding this comment.
Let's also remove max_samples_per_query? It is removed as well
|
@aclaygray thank you!. Do you mind also signing the DCO? |
aclaygray
force-pushed
the
RemoveMaxSeriesPerQueryReferences
branch
2 times, most recently
from
aa7c67c to
ee93cff
Compare
|
@yeya24 , @friedrichg , sorry took me a little while to get back to this. I believe I have done all the required steps. Please let me know otherwise, thanks! |
| tenant2: | ||
| max_samples_per_query: 1000000 | ||
| max_series_per_metric: 100000 | ||
| max_series_per_query: 100000 |
There was a problem hiding this comment.
it should be max_fetched_series_per_query for consistency
There was a problem hiding this comment.
🤦 , thanks for pointing this out.
aclaygray
force-pushed
the
RemoveMaxSeriesPerQueryReferences
branch
from
627a189 to
5b647dc
Compare
aclaygray
force-pushed
the
RemoveMaxSeriesPerQueryReferences
branch
from
5b647dc to
3dfbd00
Compare
| max_series_per_user: 0 | ||
| max_samples_per_query: 100000 | ||
| max_series_per_query: 100000 | ||
| max_series_per_user: |
There was a problem hiding this comment.
Seems to be missing a 0
| max_samples_per_query: 100000 | ||
| max_series_per_query: 100000 | ||
| max_series_per_user: | ||
| exitmax_fetched_series_per_query: 100000 |
aclaygray
force-pushed
the
RemoveMaxSeriesPerQueryReferences
branch
from
0eb21d2 to
7e2bc04
Compare
|
Hey @aclaygray sorry for the late review. I think the PR is good and I'd like to merge this. Can you please help rebase your PR against master? Thanks |
Remove references to max_samples_per_query from docs Signed-off-by: Andrew Gray <agray@splunk.com>
Signed-off-by: Andrew Gray <agray@splunk.com>
Signed-off-by: Andrew Gray <agray@splunk.com>
aclaygray
force-pushed
the
RemoveMaxSeriesPerQueryReferences
branch
from
7e2bc04 to
a34e5e0
Compare
|
@yeya24 thanks for the follow-up. Done! |
|
Thanks! @aclaygray |
4 participants
What this PR does:
Updates documentation to remove reference to deprecated
max-series-per-querythat was removed here, but some of its documentation remained.I found these during an investigation to why I received the following error when upgrading from
1.17.1to1.19.0:Figured it would save someone else some time if it were to pop up after copying over some existing examples from the docs.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]