Skip to content

return 401 when tenant ID is missing in PRW2#7389

Merged
CharlieTLe merged 1 commit into
cortexproject:masterfrom
SungJin1212:return-401-on-prw2-handler
Apr 1, 2026
Merged

return 401 when tenant ID is missing in PRW2#7389
CharlieTLe merged 1 commit into
cortexproject:masterfrom
SungJin1212:return-401-on-prw2-handler

Conversation

@SungJin1212
Copy link
Copy Markdown
Member

Return 401 when the tenant ID is missing in the PRW2 handler.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the return-401-on-prw2-handler branch from fa7a710 to 30d010f Compare March 31, 2026 11:31
Copy link
Copy Markdown
Member

@CharlieTLe CharlieTLe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is it worth logging a warning that the request was rejected?

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 31, 2026
@SungJin1212
Copy link
Copy Markdown
Member Author

@CharlieTLe
I'm not sure the server-side logging is necessary in this case.

@CharlieTLe CharlieTLe merged commit b2c0475 into cortexproject:master Apr 1, 2026
35 checks passed
CharlieTLe pushed a commit to CharlieTLe/cortex that referenced this pull request Apr 6, 2026
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size/S type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants