🧹 Code Health: Remove unused DBus proxy methods#35
🧹 Code Health: Remove unused DBus proxy methods#35google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
Removes the unused `get_devices` method from the `Manager` trait and the `delete_enrolled_fingers` method and `scan_type` property from the `Device` trait in `src/fprint_dbus.rs`. These methods were not used in the codebase and their removal improves code health and declutters the interface. * src/fprint_dbus.rs: Remove unused methods.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🧹 Code Health Improvement: Removed unused DBus proxy methods.
What:
Removed the following unused methods from
src/fprint_dbus.rs:Manager::get_devicesDevice::delete_enrolled_fingersDevice::scan_typeWhy:
These methods were defined in the DBus proxy traits but were not used anywhere in the application. Removing them simplifies the interface and reduces dead code, improving maintainability.
Verification:
cargo checkpasses without errors.cargo testpasses without regressions.grepthat these methods are not used in the codebase.Result:
The
src/fprint_dbus.rsfile is now cleaner and only contains the methods that are actually used by the application.PR created automatically by Jules for task 13852539151104752134 started by @jotuel