Skip to content

🧹 Code Health: Remove unused DBus proxy methods#35

Closed
google-labs-jules[bot] wants to merge 1 commit intomainfrom
code-health-dbus-cleanup-13852539151104752134
Closed

🧹 Code Health: Remove unused DBus proxy methods#35
google-labs-jules[bot] wants to merge 1 commit intomainfrom
code-health-dbus-cleanup-13852539151104752134

Conversation

@google-labs-jules
Copy link
Contributor

🧹 Code Health Improvement: Removed unused DBus proxy methods.

What:
Removed the following unused methods from src/fprint_dbus.rs:

  • Manager::get_devices
  • Device::delete_enrolled_fingers
  • Device::scan_type

Why:
These methods were defined in the DBus proxy traits but were not used anywhere in the application. Removing them simplifies the interface and reduces dead code, improving maintainability.

Verification:

  • Verified that cargo check passes without errors.
  • Verified that cargo test passes without regressions.
  • Confirmed via grep that these methods are not used in the codebase.

Result:
The src/fprint_dbus.rs file is now cleaner and only contains the methods that are actually used by the application.


PR created automatically by Jules for task 13852539151104752134 started by @jotuel

Removes the unused `get_devices` method from the `Manager` trait and the `delete_enrolled_fingers` method and `scan_type` property from the `Device` trait in `src/fprint_dbus.rs`. These methods were not used in the codebase and their removal improves code health and declutters the interface.

* src/fprint_dbus.rs: Remove unused methods.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@jotuel jotuel closed this Feb 14, 2026
@jotuel jotuel deleted the code-health-dbus-cleanup-13852539151104752134 branch February 14, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant