⚡ Cache DBus DeviceProxy to improve performance#65
⚡ Cache DBus DeviceProxy to improve performance#65google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
Avoid creating a new DeviceProxy for every `list_enrolled_fingers` call. Instead, create it once when the device is found and store it in `AppModel`. This reduces allocation overhead and potential DBus introspection traffic. Changes: - `AppModel` now stores `Option<DeviceProxy<'static>>`. - `find_device` returns both the object path and the proxy. - `list_enrolled_fingers_dbus` accepts a reference to an existing proxy. - `Message::DeviceFound` carries the proxy along with the path.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
jotuel
deleted the
jules-perf-dbus-proxy-caching-16196709234226409125
branch
1 participant
Implemented caching for the DBus DeviceProxy to optimize repeated calls to
list_enrolled_fingers. This avoids recreating the proxy (and potentially re-introspecting) every time the list of fingers is refreshed.Key changes:
device_proxyfield toAppModel.find_deviceto return the constructed proxy.DeviceFoundmessage to transport the proxy.list_fingers_taskto use the cached proxy.PR created automatically by Jules for task 16196709234226409125 started by @jotuel