Redelegate and Unbond never check denomination in transaction

[kwunyeung]

Summary of Bug

Both redelegation and unbond tx can be processed even if the amount is specified with denom other than uatom.

e.g.

Redelegation
https://cosmos.bigdipper.live/transactions/7D153586C7FC707708F954DD5F7C795745DC99AF11C7CFAE0458A87F2A5388AA

Unbonding
https://cosmos.bigdipper.live/transactions/83D4D5CFDE8AC2F5B340A5BF275FDF8C9FDAB5604C5B488D44F7E1F65A548913

The number of shares did updated and the redelegation/unbonding have been created. This is rather an inconsistency in the message and the operation. If it only take shares, then the message should not require submitting in coin.

On the other hand, the doc in LCD show shares in the example

https://cosmos.network/rpc/#/ICS21/post_staking_delegators__delegatorAddr__redelegations

and it will give error if number of shares is specified in the request. It takes coin as well.

Version

v0.34.7

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[rigelrozanski]

good catch

[alexanderbez]

Thanks @kwunyeung! The concept of shares has been removed from both the messages and the outputs of unbondings/redelegations. Users provide an amount (currently Coin). So we can either:

1. Check the denom against k.Params().BondDenom
2. Change the Amount to an sdk.Int

I'm more partial to (1) but both should work.

[fedekunze]

Note: this is an UX bug, it does not affect the state machine as the tokens are converted to shares (worth of params.BondDenom) on the redelegation and unbond funcs within the staking Keeper.