EditValidator command do not support min-self-delegation

[whunmr]

Summary of Bug

EditValidator command do not support flag --min-self-delegation

Version

1536f96e8b64707f859e0f54c028c922e6532c5d
Fri Jul 19 15:47:58 2019 +0100
master

Steps to Reproduce

$ gaiacli tx staking edit-validator --min-self-delegation=1000000  --from=validator --chain-id=test

ERROR: unknown flag: --min-self-delegation

fix

Add flagset in code of GetCmdEditValidator:

	cmd.Flags().AddFlagSet(FsMinSelfDelegation)

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

This is intentional -- a validator cannot change this value once created. Choose wisely ;-)

[whunmr]

Thanks, got it. @alexanderbez

Maybe then we do not need the related code in func GetCmdEditValidator any more.

			var newMinSelfDelegation *sdk.Int

			minSelfDelegationString := viper.GetString(FlagMinSelfDelegation)
			if minSelfDelegationString != "" {
				msb, ok := sdk.NewIntFromString(minSelfDelegationString)
				if !ok {
					return fmt.Errorf(types.ErrMinSelfDelegationInvalid(types.DefaultCodespace).Error())
				}
				newMinSelfDelegation = &msb
			}

[alexanderbez]

Ahhh great catch @whunmr! Indeed we do allow it to change, but only increase:

		if !(*msg.MinSelfDelegation).GT(validator.MinSelfDelegation) {
			return ErrMinSelfDelegationDecreased(k.Codespace()).Result()
		}

---

@fedekunze apologies. Do you mind re-opening the PR?

[fedekunze]

reopened