Skip to content

Remove Internal from Module Spec + Update Modules #5646

@alexanderbez

Description

@alexanderbez

As a result of #5533, the module pattern of internal no longer serves our needs. This is primarily due to the following:

  • Needing access to types.proto. We cannot get access to these message definitions if they're in internal/.
  • We've done a great job of testing cleanup (e.g. removing x/mock) so that there is less dependency hell.
  • We end up aliasing 90+% of the module anyway.

So the only "win" of internal/ is simply developer UX of not needing to import multiple packages. However, this is moot as any basic IDE should auto-import for you.

  • x/bank
  • x/crisis
  • x/evidence
  • x/mint
  • x/upgrade

/cc @fedekunze @marbar3778 @jackzampolin @hschoenburg


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions