-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Labels
S:proposal acceptedT: API BreakingBreaking changes that impact APIs and the SDK only (not state machine).Breaking changes that impact APIs and the SDK only (not state machine).help wanted
Description
Summary
Remove alias.go files in favor of more verbose import names such as <modulename>types and <modulename>keeper
Problem Definition
alias.go can be useful when managing access to internal types, but the sdk does not use internals anymore. Currently I believe its usage is purely aesthetic.
I think verbose import names are especially useful for new developers to the codebase who might not be familiar with the differences between keeper/ and types/. Verbose import names indicate clearly which package the type comes from. I've also found alias.go to be out dated do to lack of enforcement of updating it on unused types (perhaps from the types being directly imported).
Proposal
Remove alias.go, use verbose import names. Remove from module design spec as well.
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged
- Contributor assigned/self-assigned
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
S:proposal acceptedT: API BreakingBreaking changes that impact APIs and the SDK only (not state machine).Breaking changes that impact APIs and the SDK only (not state machine).help wanted