Update ante handlers to use SignatureV2#6428
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6428 +/- ##
==========================================
- Coverage 62.79% 56.85% -5.95%
==========================================
Files 251 479 +228
Lines 16306 28796 +12490
==========================================
+ Hits 10240 16371 +6131
- Misses 5361 11268 +5907
- Partials 705 1157 +452 |
…ronc/6213-ante-sig-verify
…ronc/6213-ante-sig-verify
…s-sdk into aaronc/6213-ante-sig-verify
|
It would be great if someone else familiar with the ante handler stack could take a look at this @alexanderbez @alessio @jgimeno. It’s in the critical path for the proto migration |
AdityaSripal
left a comment
There was a problem hiding this comment.
The decorators all look correct to me. Is this intended to be a backwards-compatible change?
If so, would it make more sense to implement these as separate decorators SigVerificationV2Decorator, so that people could use the old versions if they wish?
would prefer an approval from one of the SDK code owners before merging
It should be backwards compatible as is. i.e. these decorators are doing the exact same thing they were before except using an API that also supports proto tx’s. So l don’t think making them separate decorators is actually necessary. Thanks for reviewing the logic! |
* Update ante handlers to use SignatureV2 * WIP on test fixes * WIP on test fixes * Debugging CLI Tests * CHANGELOG.md * CHANGELOG * Add missing tests for ante * Add tests for verify signatures * Update verify tests * Fix register codec issue * debug * Cleanup * Fix verify signature tests * Remove viper * remove keyring usage * Fix review changes * Fix simapp * Fix ante tests * Add reference issue * Add test for multisignature * Wrap sign error with sig * Fix verify sign test * Fix CHANGELOG.md Co-authored-by: sahith-narahari <sahithnarahari@gmail.com> Co-authored-by: anilCSE <anil@vitwit.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.
This PR:
SigVerificationDecoratorandSigGasConsumeDecoratornow work with theSignatureV2infrastructure introduced in Add SignatureV2 infrastructure #6373 .SignatureVerificationGasConsumernow has the signature:func(meter sdk.GasMeter, sig signing.SignatureV2, params types.Params) error.NewAnteHandlerandNewSigVerificationDecoratorboth now take aSignModeHandlerparameter.SigVerifiableTxinterface now has aGetSignaturesV2() ([]signing.SignatureV2, error)method and no longer hasGetSignaturesandGetSignBytesmethods.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer