Remove GetSignatures from SigVerifiableTx#6550
Merged
mergify[bot] merged 14 commits intomasterfrom Sep 2, 2020
Merged
Conversation
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6550 +/- ##
==========================================
- Coverage 54.99% 54.99% -0.01%
==========================================
Files 562 562
Lines 38683 38703 +20
==========================================
+ Hits 21275 21283 +8
- Misses 15662 15671 +9
- Partials 1746 1749 +3 |
fedekunze
reviewed
Jun 30, 2020
Contributor
fedekunze
left a comment
fedekunze
left a comment
There was a problem hiding this comment.
ACK. Can you add a test for the MultiSignatureData case?
Contributor
|
@aaronc mind fixing the conflicts? |
Member
Author
|
@fedekunze I'm waiting on #6661 to finish this. |
fedekunze
approved these changes
Sep 2, 2020
| var err error | ||
| sigData, err := ModeInfoAndSigToSignatureData(si.ModeInfo, sigs[i]) | ||
| if err != nil { | ||
| return nil, err |
Contributor
There was a problem hiding this comment.
nit, wrap error with signer info index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #6213
In #6428,
GetSignaturesV2was added toSigVerifiableTxand is now used for signature verification in the ante handlers.This PR now removes
GetSignaturesfromSigVerifiableTxbecause it is no longer needed and can't actually be safely used (because it exposes encoding details such as amino or proto encoding of multi-signatures).Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes