-
Notifications
You must be signed in to change notification settings - Fork 4.2k
document how to create a new key type and add it to the keyring #6500
Copy link
Copy link
Closed
Labels
Milestone
Description
Summary
- document how to create a new key type and add it to the keyring
Problem Definition
Currently, the process of adding a new key type (eg: The Eth's secp256k1 used on Ethermint) to the keyring in not fully documented/tested, and it would be extremely helpful to add a dev guide.
Proposal
- Add a document/guide to add and register a new key type to the keyring that's used for custom account types
- Ideally, test the guide with a custom key type/algorithm. Currently, we only have a test for a not supported algorithm option (
notSupportedAlgo) that uses the same defaulthd.Secp256k1type. This will prevent issues like client/keys: --algo flag silently falls back to default if user supplied algo is not supported #6402 from happening again.
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged
- Contributor assigned/self-assigned
Reactions are currently unavailable