fix: make chain-id flag not strictly required for tx commands#10184
Merged
mergify[bot] merged 6 commits intomasterfrom Sep 22, 2021
Merged
fix: make chain-id flag not strictly required for tx commands#10184mergify[bot] merged 6 commits intomasterfrom
mergify[bot] merged 6 commits intomasterfrom
Conversation
|
Visit https://dashboard.github.orijtech.com?back=0&pr=10184&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
amaury1093
approved these changes
Sep 21, 2021
Contributor
amaury1093
left a comment
There was a problem hiding this comment.
Nice! Could you add a changelog entry?
Codecov Report
@@ Coverage Diff @@
## master #10184 +/- ##
=======================================
Coverage 63.72% 63.73%
=======================================
Files 573 573
Lines 53766 53764 -2
=======================================
+ Hits 34263 34264 +1
+ Misses 17555 17552 -3
Partials 1948 1948
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
chain-id's can be specified in a client config to be used in CLI commands. This PR changes the ChainID flag to no longer be explicitly required, as this value can come from clientCtx via config.
Closes: #9644
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change