Skip to content

feat(mint): Implement custom inflation function.#10441

Merged
mergify[bot] merged 4 commits intocosmos:masterfrom
arijitAD:calc-inflation
Nov 8, 2021
Merged

feat(mint): Implement custom inflation function.#10441
mergify[bot] merged 4 commits intocosmos:masterfrom
arijitAD:calc-inflation

Conversation

@arijitAD
Copy link
Copy Markdown
Contributor

@arijitAD arijitAD commented Oct 26, 2021 •
edited
Loading

Description

We want to use this feature in Akash Network.

The Akash whitepaper defines a time-based function for the inflation: I(t). The way cosmos-sdk currently calculates inflation is different as compared to what the Akash whitepaper prescribes. So, we need the cosmos-sdk to accept a custom function to calculate inflation. When the custom function isn't provided, it should use the default inflation calculation logic as it currently does.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@arijitAD arijitAD changed the title Implement custom inflation function. feat(x/mint): Implement custom inflation function. Oct 26, 2021
@arijitAD arijitAD changed the title feat(x/mint): Implement custom inflation function. feat(mint): Implement custom inflation function. Oct 26, 2021
@arijitAD arijitAD mentioned this pull request Oct 26, 2021
Open
19 tasks
@amaury1093
Copy link
Copy Markdown
Contributor

amaury1093 commented Oct 26, 2021

Hey @arijitAD thanks for the PR! Could you link an issue/discussion about this, or provide some information in the PR description?

@arijitAD arijitAD mentioned this pull request Oct 27, 2021
Merged
12 tasks
@arijitAD
Copy link
Copy Markdown
Contributor Author

arijitAD commented Oct 27, 2021

Hey @arijitAD thanks for the PR! Could you link an issue/discussion about this, or provide some information in the PR description?

Sure, here are the related PRs with some discussions:

amaury1093
amaury1093 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. it's a small API-breaking change, but imo useful.

alexanderbez
alexanderbez previously requested changes Oct 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending @AmauryM requested changes.

@arijitAD arijitAD requested a review from alexanderbez November 2, 2021 06:14
@tac0turtle tac0turtle requested a review from amaury1093 November 8, 2021 10:34
@tac0turtle tac0turtle dismissed alexanderbez’s stale review November 8, 2021 10:35

Dissmissing review as the changes were handled

@mergify mergify bot merged commit a9af2c3 into cosmos:master Nov 8, 2021
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
@arijitAD @blewater
feat(mint): Implement custom inflation function. (cosmos#10441)
d2acfd8 
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

We want to use this feature in [Akash Network](https://akash.network/).

The [Akash whitepaper](https://whitepaper.io/document/632/akash-network-whitepaper) defines a time-based function for the inflation: `I(t)`. The way `cosmos-sdk` currently calculates inflation is different as compared to what the Akash whitepaper prescribes. So, we need the `cosmos-sdk` to accept a custom function to calculate inflation. When the custom function isn't provided, it should use the default inflation calculation logic as it currently does.

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@arijitAD arijitAD deleted the calc-inflation branch January 11, 2022 18:06
@anilcse anilcse mentioned this pull request May 10, 2022
Closed
4 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@arijitAD
feat(mint): Implement custom inflation function. (cosmos#10441)
0d967fd 
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

We want to use this feature in [Akash Network](https://akash.network/).

The [Akash whitepaper](https://whitepaper.io/document/632/akash-network-whitepaper) defines a time-based function for the inflation: `I(t)`. The way `cosmos-sdk` currently calculates inflation is different as compared to what the Akash whitepaper prescribes. So, we need the `cosmos-sdk` to accept a custom function to calculate inflation. When the custom function isn't provided, it should use the default inflation calculation logic as it currently does.

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@amaury1093 amaury1093 Awaiting requested review from amaury1093

2 more reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@uwezukwechibuzor uwezukwechibuzor uwezukwechibuzor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amaury1093 amaury1093

Labels

C:x/mint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arijitAD @amaury1093 @alexanderbez @tac0turtle @uwezukwechibuzor