Skip to content

feat: tx with generate-only and offline shouldn't use chain id#10710

Merged
mergify[bot] merged 12 commits intomasterfrom
likhita/fix-transactions
Dec 10, 2021
Merged

feat: tx with generate-only and offline shouldn't use chain id#10710
mergify[bot] merged 12 commits intomasterfrom
likhita/fix-transactions

Conversation

@likhita-809
Copy link
Copy Markdown
Contributor

Description

chain-id shouldn't be required for creating a tx with --generate-only and --offline

ref: #9407


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Dec 9, 2021
@likhita-809 likhita-809 mentioned this pull request Dec 9, 2021
20 tasks
@mergify mergify bot merged commit 21e6f7c into master Dec 10, 2021
@mergify mergify bot deleted the likhita/fix-transactions branch December 10, 2021 12:16
@amaury1093 amaury1093 mentioned this pull request May 20, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants