feat: tx with generate-only and offline shouldn't use chain id#10710
Merged
mergify[bot] merged 12 commits intomasterfrom Dec 10, 2021
Merged
feat: tx with generate-only and offline shouldn't use chain id#10710mergify[bot] merged 12 commits intomasterfrom
mergify[bot] merged 12 commits intomasterfrom
Conversation
added 2 commits
December 9, 2021 16:10
alexanderbez
suggested changes
Dec 9, 2021
added 2 commits
December 9, 2021 22:49
…khita/fix-transactions
alexanderbez
approved these changes
Dec 9, 2021
atheeshp
approved these changes
Dec 10, 2021
…khita/fix-transactions
…cosmos-sdk into likhita/fix-transactions
tac0turtle
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
chain-id shouldn't be required for creating a tx with --generate-only and --offline
ref: #9407
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change