fix: adding checks to ensure coin denoms are sorted in Balance during Validate (backport #9829)#10849
Merged
amaury1093 merged 8 commits intorelease/v0.45.xfrom Jan 3, 2022
Merged
Conversation
19 tasks
…ergify/bp/release/v0.45.x/pr-9829
fedekunze
approved these changes
Dec 30, 2021
ValarDragon
approved these changes
Jan 3, 2022
zakir-web3
pushed a commit
to PundiAI/cosmos-sdk
that referenced
this pull request
Apr 8, 2022
…ng `Validate` (backport cosmos#9829) (cosmos#10849) * adding checks to ensure denoms are sorted (cherry picked from commit ce1e650) * updating changelog (cherry picked from commit 2cea5e5) # Conflicts: # CHANGELOG.md * refactoring balance.coin validation (cherry picked from commit 40d22c7) * adding 0 value coin test case (cherry picked from commit 2468b64) * added valid sorted coin testcase (cherry picked from commit 66b91ee) * updating changelog (cherry picked from commit 59b788a) # Conflicts: # CHANGELOG.md * conflicts Co-authored-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
JimLarson
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Jul 7, 2022
…ng `Validate` (backport cosmos#9829) (cosmos#10849) * adding checks to ensure denoms are sorted (cherry picked from commit ce1e650) * updating changelog (cherry picked from commit 2cea5e5) # Conflicts: # CHANGELOG.md * refactoring balance.coin validation (cherry picked from commit 40d22c7) * adding 0 value coin test case (cherry picked from commit 2468b64) * added valid sorted coin testcase (cherry picked from commit 66b91ee) * updating changelog (cherry picked from commit 59b788a) # Conflicts: # CHANGELOG.md * conflicts Co-authored-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…ng `Validate` (backport cosmos#9829) (cosmos#10849) * adding checks to ensure denoms are sorted (cherry picked from commit ce1e650) * updating changelog (cherry picked from commit 2cea5e5) # Conflicts: # CHANGELOG.md * refactoring balance.coin validation (cherry picked from commit 40d22c7) * adding 0 value coin test case (cherry picked from commit 2468b64) * added valid sorted coin testcase (cherry picked from commit 66b91ee) * updating changelog (cherry picked from commit 59b788a) # Conflicts: # CHANGELOG.md * conflicts Co-authored-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9829 done by Mergify.
Cherry-pick of 2cea5e5 has failed:
Cherry-pick of 59b788a has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com