refactor: remove deprecated vote option#10854
Merged
mergify[bot] merged 16 commits intomasterfrom Jan 26, 2022
Merged
Conversation
atheeshp
changed the title
amaury1093
reviewed
Jan 4, 2022
| // Deprecated: Prefer to use `options` instead. This field is set in queries | ||
| // if and only if `len(options) == 1` and that option has weight 1. In all | ||
| // other cases, this field will default to VOTE_OPTION_UNSPECIFIED. | ||
| VoteOption option = 3 [deprecated = true]; |
Contributor
|
Hey, what's the status on this. Is it ready to be reviewed? |
Contributor
Author
Contributor
|
This should be unblocked now @atheeshp. Do you mind updating the PR and resolving the conflicts so we can merge 🙏 |
cmwaters
reviewed
Jan 24, 2022
Contributor
cmwaters
left a comment
cmwaters
left a comment
There was a problem hiding this comment.
looks like there are a few other places that uses vote.Option that we need to remove
Codecov Report
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
- Coverage 65.95% 65.90% -0.05%
==========================================
Files 647 677 +30
Lines 65873 68059 +2186
==========================================
+ Hits 43444 44854 +1410
- Misses 19941 20498 +557
- Partials 2488 2707 +219
|
tac0turtle
approved these changes
Jan 25, 2022
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
lgtm, should we add a changelog entry so client libraries are aware?
cmwaters
approved these changes
Jan 26, 2022
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10792
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change