chore: move server.GenerateCoinKey and server.GenerateSaveCoinKey to …

[robert-zaremba]

Cleaning it and moving the breaking "test" code to testutils
Related to: #10956

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[anilcse]

makes sense as we are not using it anywhere else

[amaury1093]

Definitely makes sense, but we need to solve the import cycle

[robert-zaremba]

ledger_mock.go cause import cycle. That's bad... testutil is a good place for this functions, because we have testutil.TestMnemonic there as well.

testutil/known_values.go imho should be in testutil/testdata package. What do you think about doing that breaking change?

[robert-zaremba]

However ... not sure if we can backport it then to 0.45 RC... I would say yes - because it's moving a test object.

[amaury1093]

ledger_mock.go cause import cycle. That's bad... testutil is a good place for this functions, because we have testutil.TestMnemonic there as well.

Makes sense to me 👍

For v0.45, I would really prefer to not break any API. can we just do some patch like #10935 (comment) ?

[robert-zaremba]

In v0.45, there is no breaking change now. The only breaking change I'm proposing is to:

testutil/known_values.go imho should be in testutil/testdata package.

But... it would be good to do the same changes in 0.44 - but there we can't touch known_values.go

[alexanderbez]

Agree with @robert-zaremba here 👍