Closed
Conversation
This reverts commit ea433e7.
tac0turtle
approved these changes
Apr 11, 2022
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
LGTM, could you add a changlog entry pleas
alexanderbez
suggested changes
Apr 11, 2022
| return nil, errors.ToRosetta(err) | ||
| } | ||
|
|
||
| price, err := sdk.ParseDecCoin(metadata["gas_price"].(string)) |
Contributor
There was a problem hiding this comment.
we should be safe and have explicit type assertions on these metadata fields and return an error when the type is invalid. Otherwise, this could could panic of metadata structure changes.
anilcse
reviewed
Apr 11, 2022
| "time" | ||
|
|
||
| "github.com/coinbase/rosetta-sdk-go/types" | ||
| clientflags "github.com/cosmos/cosmos-sdk/client/flags" |
| // DefaultOffline defines the default offline value | ||
| DefaultOffline = false | ||
| // DefaultEnableDefaultFeeSuggest indicates to use fee suggestion | ||
| DefaultEnableDefaultFeeSuggest = false |
Contributor
There was a problem hiding this comment.
odd to read, we can remove Default prefix and address the changes that @alexanderbez suggested for naming
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Contributor
Author
|
My apologies.. miscreated pr with outdated and invalid test branch. I'll create again with right branch after applying your suggestions. |
This was referenced Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat/fix to enhance rosetta support
Description
followup of #10766
Closes: #10618
we did integration test with coinbase so this PR includes all of our fixes and features requested from coinbase.
features:
/construction/metadata/construction/metadatafixes:
/blockreturns with nil pointer address when a request has both of index and hashAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change