Skip to content

fix: Add SafeSub for sdk.Coin#11630

Merged
mergify[bot] merged 9 commits intocosmos:masterfrom
NagaTulasi:tulasi/safesub
Apr 14, 2022
Merged

fix: Add SafeSub for sdk.Coin#11630
mergify[bot] merged 9 commits intocosmos:masterfrom
NagaTulasi:tulasi/safesub

Conversation

@NagaTulasi
Copy link
Copy Markdown
Contributor

@NagaTulasi NagaTulasi commented Apr 13, 2022

Description

Closes: #11603


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@NagaTulasi NagaTulasi changed the title safesub added fix: Add SafeSub for sdk.Coin Apr 13, 2022
@NagaTulasi NagaTulasi marked this pull request as ready for review April 13, 2022 11:03
Copy link
Copy Markdown
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a changelog entry?

Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending changelog entry)

@mergify mergify bot merged commit 6ff6dce into cosmos:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SafeSub for sdk.Coin

6 participants