refactor: make Cosmovisor use cobra#11823
Merged
mergify[bot] merged 18 commits intomainfrom May 2, 2022
Merged
Conversation
4 tasks
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
tac0turtle
reviewed
May 2, 2022
tac0turtle
reviewed
May 2, 2022
| }, | ||
| } | ||
|
|
||
| func printVersion(logger *zerolog.Logger, args []string) error { |
Contributor
There was a problem hiding this comment.
should we use the logger interface from tendermint to keep consistent with sdk?
Contributor
Author
There was a problem hiding this comment.
The problem is that interface does not allow us to disable the logger.
Contributor
There was a problem hiding this comment.
you would pass it a noop logger, this is what we use to do in tendermint
Contributor
There was a problem hiding this comment.
Correct -- zerolog has a no-op logger.
alexanderbez
approved these changes
May 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #11823 +/- ##
==========================================
+ Coverage 66.00% 66.03% +0.02%
==========================================
Files 670 681 +11
Lines 70714 71443 +729
==========================================
+ Hits 46674 47176 +502
- Misses 21369 21563 +194
- Partials 2671 2704 +33
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11789
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change