fix: change SimulationState.InitialStake to sdkmath.Int#11855
Merged
tac0turtle merged 4 commits intomainfrom May 2, 2022
Merged
fix: change SimulationState.InitialStake to sdkmath.Int#11855tac0turtle merged 4 commits intomainfrom
tac0turtle merged 4 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11855 +/- ##
==========================================
- Coverage 66.03% 65.97% -0.06%
==========================================
Files 681 670 -11
Lines 71443 70717 -726
==========================================
- Hits 47174 46654 -520
+ Misses 21566 21394 -172
+ Partials 2703 2669 -34
|
Contributor
Author
|
Rosetta tests seem to be failing, but I didn't messed with that (at least directly) |
Contributor
Yes, unrelated to this PR. Feel free to ignore it. See: #11846 |
alexanderbez
approved these changes
May 2, 2022
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
wohoo first core PR! 🎉
alexanderbez
approved these changes
May 2, 2022
tac0turtle
approved these changes
May 2, 2022
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* fix: change SimulationState.InitialStake to sdkmath.Int * cl * aleks' suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11795
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change