fix: Simulation is not deterministic due to GenSignedMockTx (backport #12374)#12403
Merged
alexanderbez merged 2 commits intorelease/v0.46.xfrom Jul 14, 2022
Merged
Conversation
19 tasks
Contributor
|
@Muggle-Du do you think you could help address the merge conflicts here from backporting #12374? |
Contributor
|
@Mergifyio rebase |
(cherry picked from commit 17dc431) # Conflicts: # CHANGELOG.md # simapp/helpers/test_helpers.go # simapp/test_helpers.go # x/authz/simulation/operations.go # x/bank/simulation/operations.go # x/genutil/gentx_test.go # x/gov/simulation/operations.go # x/group/simulation/operations.go # x/nft/simulation/operations.go # x/simulation/util.go # x/slashing/simulation/operations.go
Contributor
Author
✅ Branch has been successfully rebased |
c494b87 to
0295da5
Compare
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
Merge conflicts need to be addressed :)
Contributor
sorry for missing this msg, I can help with this |
Contributor
|
I can do it otherwise, that's why I was assigned to the PR. |
julienrbrt
approved these changes
Jul 14, 2022
alexanderbez
approved these changes
Jul 14, 2022
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #12374 done by Mergify.
Cherry-pick of 17dc431 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com