Skip to content

feat: allow custom authority and inflation function when using app-wiring #12660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 10 commits into from
Jul 21, 2022
Merged

feat: allow custom authority and inflation function when using app-wiring #12660

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7aa3be0
feat: don't hardcode authority and inflation function when using app-…
julienrbrt Jul 20, 2022
a2ce0b9
add comments
julienrbrt Jul 20, 2022
58d2e8b
update comment
julienrbrt Jul 20, 2022
3c9dce0
name clashing
julienrbrt Jul 20, 2022
7d8f14f
improve comment
julienrbrt Jul 20, 2022
7ca8844
Merge branch 'main' into julien/app-wiring-func
julienrbrt Jul 21, 2022
d623377
simplify implementation
julienrbrt Jul 21, 2022
d0d947c
simplify comment
julienrbrt Jul 21, 2022
b034038
revert update
julienrbrt Jul 21, 2022
fdbd8be
Merge branch 'main' into julien/app-wiring-func
julienrbrt Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert update
  • Loading branch information
@julienrbrt
julienrbrt committed Jul 21, 2022
commit b034038b372ed588802b19958afd506648c2c664
4 changes: 1 addition & 3 deletions server/tm_cmds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,7 @@ func makeKeyMigrateCmd() *cobra.Command {
return fmt.Errorf("constructing database handle: %w", err)
}

// Note storeName argument has been added in TM v0.35.9
// I have set it to "" - please verify if correct
if err = keymigrate.Migrate(ctx, "", db); err != nil {
if err = keymigrate.Migrate(ctx, db); err != nil {
return fmt.Errorf("running migration for context %q: %w",
dbctx, err)
}
Expand Down