Skip to content

fix: update redelegation stringer#14064

Merged
amaury1093 merged 5 commits intorelease/v0.47.xfrom
julien/redelegation-stringer
Nov 29, 2022
Merged

fix: update redelegation stringer#14064
amaury1093 merged 5 commits intorelease/v0.47.xfrom
julien/redelegation-stringer

Conversation

@julienrbrt
Copy link
Copy Markdown
Contributor

Description

Discovered in #14046 that the String() function didn't print all fields.
Ref: #14046 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team November 29, 2022 11:05
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog before merging

@sonarqubecloud
Copy link
Copy Markdown

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@amaury1093 amaury1093 merged commit 33192dd into release/v0.47.x Nov 29, 2022
@amaury1093 amaury1093 deleted the julien/redelegation-stringer branch November 29, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants