Skip to content

chore: lint tests too#14228

Closed
faddat wants to merge 2 commits intocosmos:mainfrom
faddat:patch-27
Closed

chore: lint tests too#14228
faddat wants to merge 2 commits intocosmos:mainfrom
faddat:patch-27

Conversation

@faddat
Copy link
Copy Markdown
Contributor

@faddat faddat commented Dec 8, 2022

Description

Since we are using golangci-lint for formatting and linting, we should also apply this to tests for consistency.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle
Copy link
Copy Markdown
Contributor

@faddat are there many issues with tests?I thought we were linting tests lol

@julienrbrt
Copy link
Copy Markdown
Contributor

Superseded by #14268

@julienrbrt julienrbrt closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants