fix: add simulation tests for new param change#14728
Merged
julienrbrt merged 46 commits intomainfrom Jan 27, 2023
Merged
Conversation
github-actions
bot
added
C:Simulations
C:x/auth
C:x/bank
C:x/distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
19 tasks
Contributor
Author
|
I need to refactor the simulator first. Otherwise, I need to add the missing |
Contributor
There was a problem hiding this comment.
gosec found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
tac0turtle
approved these changes
Jan 26, 2023
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
Thanks for taking this on, its a nice cleanup
alexanderbez
approved these changes
Jan 27, 2023
Contributor
Author
|
Fixing the lasts tests.. |
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
(cherry picked from commit d3c3194) # Conflicts: # CHANGELOG.md # types/module/simulation.go # x/auth/simulation/params.go # x/bank/simulation/params.go # x/distribution/simulation/params.go # x/gov/simulation/operations.go # x/gov/simulation/operations_test.go # x/gov/simulation/params.go # x/mint/simulation/params.go # x/slashing/simulation/params.go # x/staking/simulation/params.go
19 tasks
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed while up streaming #14720 that the params simulation were outdated due to the params migration that happened in v0.47.
Removing the old params change simulation and re-adding them directly as normal simulation.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change